Allow HAFS app to be compiled with 64bit FMS#626
Merged
Conversation
DusanJovic-NOAA
requested review from
BinLiu-NOAA,
binli2337 and
junwang-noaa
37 tasks
junwang-noaa
approved these changes
Feb 13, 2023
binli2337
approved these changes
Feb 13, 2023
Collaborator
|
Since these changes are moving-nesting related, it would be nice if we can ask @wramstrom to look at these changes as well. Thanks! |
Collaborator
|
All tests are done with ufs-community/ufs-weather-model#1578. We are merging in this pr. |
Jili-Dong
added a commit
to Jili-Dong/fv3atm
that referenced
this pull request
Mar 7, 2023
Allow HAFS app to be compiled with 64bit FMS (NOAA-EMC#626)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Conditionally 'use' either r4 or r8 version of FMS constants module depending on which version of FMS is used.
What bug does it fix, or what feature does it add?
ufs-community/ufs-weather-model#1545
Is a change of answers expected from this PR?
No.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?